Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ariane_pkg.sv following issue #1726. This issue was encountere… #1750

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

andriami
Copy link
Contributor

@andriami andriami commented Jan 8, 2024

Modify ariane_pkg.sv following issue #1726. This issue was encountered during ASIC synthesis with DC version P-2019.03.

… encountered during ASIC synthesis with DC version P-2019.03.
Comment on lines 168 to 170
localparam int unsigned LOG2_INSTR_PER_FETCH = RVC == 1'b1 ? $clog2(
ariane_pkg::INSTR_PER_FETCH
INSTR_PER_FETCH
) : 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[verible-verilog-format] reported by reviewdog 🐶

Suggested change
localparam int unsigned LOG2_INSTR_PER_FETCH = RVC == 1'b1 ? $clog2(
ariane_pkg::INSTR_PER_FETCH
INSTR_PER_FETCH
) : 1;
localparam int unsigned LOG2_INSTR_PER_FETCH = RVC == 1'b1 ? $clog2(INSTR_PER_FETCH) : 1;

@JeanRochCoulon
Copy link
Contributor

Hello @andriami thanks for the PR. Can I ask you to sign the Eclipse agreement to become cva6 contributor ?
Moreover, there is a Verible format error to fix.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

✔️ successful run, report available here.

@andriami
Copy link
Contributor Author

andriami commented Jan 8, 2024

Hi @JeanRochCoulon,
I've just signed the Eclipse agreement. Sorry for the format error!

Copy link
Contributor

github-actions bot commented Jan 8, 2024

✔️ successful run, report available here.

@JeanRochCoulon JeanRochCoulon merged commit 59177e3 into openhwgroup:master Jan 8, 2024
4 checks passed
rohan-10xe pushed a commit to 10x-Engineers/cva6 that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants